On Mon, 15 Mar 2021 11:36:49 -0700 (PDT) no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20210315180102.3008391-1-imamm...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20210315180102.3008391-1-imamm...@redhat.com > Subject: [PATCH 0/6] pc: support user provided NIC naming/indexing > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > ./scripts/checkpatch.pl --mailback base.. > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/20210315180102.3008391-1-imamm...@redhat.com -> > patchew/20210315180102.3008391-1-imamm...@redhat.com > Switched to a new branch 'test' > c0692b4 tests: acpi: update expected blobs > 1a843d9 pci: acpi: add _DSM method to PCI devices > 6b55586 acpi: add aml_to_decimalstring() and aml_call6() helpers > 7b887f4 pci: acpi: ensure that acpi-index is unique > 4056291 pci: introduce apci-index property for PCI device > 9bd3a1b tests: acpi: temporary whitelist DSDT changes > > === OUTPUT BEGIN === > 1/6 Checking commit 9bd3a1b94c0f (tests: acpi: temporary whitelist DSDT > changes) > 2/6 Checking commit 40562915acde (pci: introduce apci-index property for PCI > device) > ERROR: Macros with complex values should be enclosed in parenthesis > #284: FILE: include/hw/acpi/pcihp.h:77: > +#define VMSTATE_PCI_HOTPLUG(pcihp, state, test_pcihp, test_acpi_index) \ > VMSTATE_UINT32_TEST(pcihp.hotplug_select, state, \ > test_pcihp), \ > VMSTATE_STRUCT_ARRAY_TEST(pcihp.acpi_pcihp_pci_status, state, \ > ACPI_PCIHP_MAX_HOTPLUG_BUS, \ > test_pcihp, 1, \ > vmstate_acpi_pcihp_pci_status, \ > - AcpiPciHpPciStatus) > + AcpiPciHpPciStatus), \ > + VMSTATE_UINT32_TEST(pcihp.acpi_index, state, \ > + test_acpi_index) probably false positive (I don't know what's wrong here and how to fix it)
> total: 1 errors, 0 warnings, 197 lines checked > > Patch 2/6 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. below warnings are intentional to follow comments style we use within aml-build.c > 3/6 Checking commit 7b887f42419a (pci: acpi: ensure that acpi-index is unique) > 4/6 Checking commit 6b555869ad66 (acpi: add aml_to_decimalstring() and > aml_call6() helpers) > WARNING: Block comments use a leading /* on a separate line > #27: FILE: hw/acpi/aml-build.c:640: > + Aml *var = aml_opcode(0x97 /* ToDecimalStringOp */); > > WARNING: Block comments use a leading /* on a separate line > #32: FILE: hw/acpi/aml-build.c:645: > + build_append_byte(var->buf, 0x00 /* NullNameOp */); > > total: 0 errors, 2 warnings, 55 lines checked > > Patch 4/6 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 5/6 Checking commit 1a843d9de55e (pci: acpi: add _DSM method to PCI devices) > WARNING: Block comments use a leading /* on a separate line > #127: FILE: hw/i386/acpi-build.c:568: > + 1 /* have supported functions */ | > > total: 0 errors, 1 warnings, 140 lines checked > > Patch 5/6 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > 6/6 Checking commit c0692b4b7df0 (tests: acpi: update expected blobs) > === OUTPUT END === > > Test command exited with code: 1 > > > The full log is available at > http://patchew.org/logs/20210315180102.3008391-1-imamm...@redhat.com/testing.checkpatch/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-de...@redhat.com