Eric Blake <ebl...@redhat.com> writes:
> On 3/16/21 8:59 AM, Markus Armbruster wrote:
>> util/yank.c and stubs/yank.c are both in libqemuutil.a, even though
>> their external symbols conflict. The linker happens to pick the
>> former. This links a bunch of unneeded code into the executables that
>> actually want the latter: qemu-io, qemu-img, qemu-nbd, and several
>> tests. Amazingly, none of them fails to link.
>>
>> To fix this, the non-stub yank.c from sourceset util_ss to sourceset
>> qmp_ss. This requires moving it from util/ to monitor/.
>>
>> Suggested-by: Paolo Bonzini <pbonz...@redhat.com>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> ---
>> {util => monitor}/yank.c | 0
>> MAINTAINERS | 2 +-
>> monitor/meson.build | 1 +
>> util/meson.build | 1 -
>> 4 files changed, 2 insertions(+), 2 deletions(-)
>> rename {util => monitor}/yank.c (100%)
>
> I'm still determining if I need an NBD pull request for soft freeze
> today; if so, I'm happy to include this one if it doesn't make it into
> the tree elsewhere first. I also consider it to be a build issue and
> therefore suitable for inclusion in -rc1 if it misses the boat today.
It's not urgent, just something I spotted when I looked for buddies of
another bug that bit me.
