On 3/17/21 6:17 AM, Thomas Huth wrote: >> ERROR:../tests/test-cutils.c:2290:test_qemu_strtosz_metric: assertion >> failed (res == 12345000): (12344999 == 12345000) > > A different failure shows up in the MSYS2 builds now, too: > > https://cirrus-ci.com/task/5180846782021632?command=test#L543
A bug in mingw's libc for strtoull() that parses "0x" incorrectly (the correct parse is "0" with the endptr pointing to 'x', and NOT pointing beyond x). Also a weakness in our testsuite - many of the tests are not asserting sane values of err, or whether res is left unchanged on error. I'm working on a patch now that I have more awareness of what's going on... -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
