On 3/23/21 4:40 AM, Markus Armbruster wrote: > Feature names should use '-', not '_'. Enforce this. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi/expr.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Thankfully no offenders ;) Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py > index ce37b426c9..01a994412d 100644 > --- a/scripts/qapi/expr.py > +++ b/scripts/qapi/expr.py > @@ -213,7 +213,7 @@ def check_features(features, info): > check_keys(f, info, source, ['name'], ['if']) > check_name_is_str(f['name'], info, source) > source = "%s '%s'" % (source, f['name']) > - check_name_lower(f['name'], info, source, permit_underscore=True) > + check_name_lower(f['name'], info, source) > check_if(f, info, source) > > > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
