24.03.2021 00:22, Paolo Bonzini wrote:
On 23/03/21 20:17, Vladimir Sementsov-Ogievskiy wrote:
+ unittest.main(argv=argv,
+ testRunner=ReproducibleTestRunner,
+ verbosity=2 if debug else 1,
+ warnings=None if sys.warnoptions else 'ignore')
def execute_setup_common(supported_fmts: Sequence[str] = (),
supported_platforms: Sequence[str] = (),
@@ -1350,7 +1354,7 @@ def execute_test(*args, test_function=None, **kwargs):
debug = execute_setup_common(*args, **kwargs)
if not test_function:
- execute_unittest(debug)
+ execute_unittest(sys.argv, debug)
else:
test_function()
If you decide to resend for some of my comments (or due to another reviewer be
more careful), I think it would be nicer to merge part of this commit which
moves us from passing object to passing ReproducibleTestRunner to the previous
commit, to not remove line that we've added in the previous commit. And here
only add argv argument.
Well, it's the price to pay to make the previous commit as independent as
possible. In particular in the previous patch there's no reason to add the
complexity of warnings.
I could make it three commits, but at some point too much splitting adds
clutter, the patches are already pretty small.
OK, they are good as is
--
Best regards,
Vladimir
