On Fri, 26 Mar 2021 19:56:26 +0400 Marc-André Lureau <marcandre.lur...@gmail.com> wrote:
> Hi > > On Fri, Mar 26, 2021 at 11:48 AM Lukas Straub <lukasstra...@web.de> wrote: > > > Hello Everyone, > > These patches increase test coverage for yank, add tests and fix bugs and > > crashes in yank in combination with chardev-change. > > Please Review. > > > > Regards, > > Lukas Straub > > > > Changes: > > -v4: > > -test: fix CharChangeTestConfig structs on stack going out of scope > > -test: move after bugfixes > > > > -v3: > > -Base on <cover.1616521341.git.lukasstra...@web.de> > > ([PATCH 0/2] yank: Always link full yank code) > > -Drop patch 1 (tests: Use the normal yank code instead of stubs in > > relevant tests) > > > > -v2: > > -test: add license > > -test: factorize testcases to a single function > > -test: test chardev_change with initialization of new chardev failing > > -fix chardev_change with initialization of new chardev failing > > -add reviewed-by and tested-by tags > > > > Based-on: <cover.1616521341.git.lukasstra...@web.de> > > ([PATCH 0/2] yank: Always link full yank code) > > > > Lukas Straub (4): > > chardev/char.c: Move object_property_try_add_child out of chardev_new > > chardev/char.c: Always pass id to chardev_new > > chardev: Fix yank with the chardev-change case > > tests: Add tests for yank with the chardev-change case > > > > MAINTAINERS | 1 + > > chardev/char-socket.c | 20 ++++- > > chardev/char.c | 77 ++++++++++------ > > include/chardev/char.h | 3 + > > tests/unit/meson.build | 3 +- > > tests/unit/test-yank.c | 199 +++++++++++++++++++++++++++++++++++++++++ > > 6 files changed, 274 insertions(+), 29 deletions(-) > > create mode 100644 tests/unit/test-yank.c > > > > -- > > 2.30.2 > > > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Alright, thank you for reviewing this. Regards, Lukas Straub --
pgpjga8Yxmhls.pgp
Description: OpenPGP digital signature