Li Zhang <zhlci...@gmail.com> writes: > On Fri, Apr 16, 2021 at 4:50 PM Markus Armbruster <arm...@redhat.com> wrote:
[...] >> As I wrote in my review of v1, this function copies from >> monitor_data_init(), monitor_init_qmp(), and monitor_flush_locked(). >> Feels like a refactoring would be in order. Doing it on top might be >> easier. > > I may misunderstand what you mean. What's the meaning of "doing it on > top" exactly? As a separate patch on top of this one. Sorry for the jargon :) [...]