On 4/19/21 9:27 PM, Richard Henderson wrote:
> On 4/19/21 12:18 PM, Philippe Mathieu-Daudé wrote:
>> Rename set_pc() as mips_cpu_set_error_pc(), declare it inlined
>> and use it in cpu.c and op_helper.c.
> 
> Why "error_pc"?  The usage in mips_cpu_set_pc certainly isn't in
> response to any kind of error...

Indeed, but I couldn't find any good name. mips_cpu_set_pc() is
already taken, as is cpu_set_pc():

static void mips_cpu_set_pc(CPUState *cs, vaddr value)

mips_cpu_state_set_pc() maybe?

Reply via email to