On Tue, 20 Apr 2021 at 16:03, Markus Armbruster <arm...@redhat.com> wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Commit 54aa3de72 ("qapi: Use QAPI_LIST_PREPEND() where possible") > > inadvertently removed the has_dependencies from the partition disk > > info, resulting in empty list being returned. > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1950833 > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > qga/commands-posix.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > > index 4299ebd96f..75dbaab68e 100644 > > --- a/qga/commands-posix.c > > +++ b/qga/commands-posix.c > > @@ -1376,6 +1376,7 @@ static GuestDiskInfoList *get_disk_partitions( > > partition = g_new0(GuestDiskInfo, 1); > > partition->name = dev_name; > > partition->partition = true; > > + partition->has_dependencies = true; > > /* Add parent disk as dependent for easier tracking of hierarchy */ > > QAPI_LIST_PREPEND(partition->dependencies, g_strdup(disk_dev)); > > This is a recent regression, and the fix is as safe as they get. Please > apply for 6.0. > > Reviewed-by: Markus Armbruster <arm...@redhat.com>
Thanks; applied to master for 6.0. -- PMM