22.04.2021 12:57, Emanuele Giuseppe Esposito wrote:
On 22/04/2021 00:09, Vladimir Sementsov-Ogievskiy wrote:
write-notifiers are used only for write-threshold. New code for such
purpose should create filters.
Let's handle write-threshold simply in generic code and drop write
notifiers at all.
Also move part of write-threshold API that is used only for testing to
the test.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
I agree that this could be split into 2-3 parts and not combining
everything into one. But I'm tired now. I can send v2 if needed, so
consider it as RFC. Or take as is if you think it's not too much-in-one.
Thank you for this patch. Since I am reworking on v2, if you want I can also
integrate this patch with mines and send everything together once I am done.
Emanuele
I'd wait several days for comments. Maybe I'll have to resend v2 of this.
Also, after this patch, is something of your patches 1-4 needed? Probably you may just
resend your series not touching write-threshold, and just note in cover-letter that
write-threshold is covered by "[PATCH] block: simplify write-threshold and drop
write notifiers"
--
Best regards,
Vladimir
