The TYPE_SPAPR_TCE_TABLE device is bus-less, thus isn't reset
automatically. Register a reset handler to get reset with the
machine.
It doesn't seem to be an issue because it is that way since the
device QDev'ifycation 8 years ago, in commit a83000f5e3f
("spapr-tce: make sPAPRTCETable a proper device").
Still, correct to have a proper API usage.
Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
---
hw/ppc/spapr_iommu.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c
index 24537ffcbd3..f7dad1dc0fe 100644
--- a/hw/ppc/spapr_iommu.c
+++ b/hw/ppc/spapr_iommu.c
@@ -24,6 +24,7 @@
#include "sysemu/kvm.h"
#include "kvm_ppc.h"
#include "migration/vmstate.h"
+#include "sysemu/reset.h"
#include "sysemu/dma.h"
#include "exec/address-spaces.h"
#include "trace.h"
@@ -302,6 +303,11 @@ static const VMStateDescription vmstate_spapr_tce_table = {
}
};
+static void spapr_tce_reset_handler(void *dev)
+{
+ device_legacy_reset(DEVICE(dev));
+}
+
static void spapr_tce_table_realize(DeviceState *dev, Error **errp)
{
SpaprTceTable *tcet = SPAPR_TCE_TABLE(dev);
@@ -324,6 +330,8 @@ static void spapr_tce_table_realize(DeviceState *dev, Error
**errp)
vmstate_register(VMSTATE_IF(tcet), tcet->liobn, &vmstate_spapr_tce_table,
tcet);
+
+ qemu_register_reset(spapr_tce_reset_handler, dev);
}
void spapr_tce_set_need_vfio(SpaprTceTable *tcet, bool need_vfio)
@@ -425,6 +433,8 @@ static void spapr_tce_table_unrealize(DeviceState *dev)
{
SpaprTceTable *tcet = SPAPR_TCE_TABLE(dev);
+ qemu_unregister_reset(spapr_tce_reset_handler, dev);
+
vmstate_unregister(VMSTATE_IF(tcet), &vmstate_spapr_tce_table, tcet);
QLIST_REMOVE(tcet, list);
--
2.26.3
