On Wed, 28 Apr 2021 16:36:52 +0200 Eric Farman <[email protected]> wrote:
> The vfio_ccw_unrealize() routine makes an unconditional attempt to > unregister every IRQ notifier, though they may not have been registered > in the first place (when running on an older kernel, for example). > > Let's mirror this behavior in the error cleanups in vfio_ccw_realize() > so that if/when new IRQs are added, it is less confusing to recognize > the necessary procedures. The worst case scenario would be some extra > messages about an undefined IRQ, but since this is an error exit that > won't be the only thing to worry about. > > And regarding those messages, let's change it to a warning instead of > an error, to better reflect their severity. The existing code in both > paths handles everything anyway. > > Signed-off-by: Eric Farman <[email protected]> > --- > > Notes: > v1->v2: > - Downgrade unregister IRQ message from error to warning [CH] > > v1: > https://lore.kernel.org/qemu-devel/[email protected]/ > > hw/vfio/ccw.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Thanks, applied.
