> -----Original Message-----
> From: Richard Henderson <[email protected]>
> Sent: Wednesday, April 28, 2021 4:13 PM
> To: Taylor Simpson <[email protected]>; [email protected]
> Cc: [email protected]; [email protected]; Brian Cain <[email protected]>
> Subject: Re: [PATCH v4 00/26] Hexagon (target/hexagon) update
>
> On 4/8/21 6:07 PM, Taylor Simpson wrote:
> > This patch series is a significant update for the Hexagon target
> > The first 16 patches address feedback from Richard Henderson
> > <[email protected]> and Philippe Mathieu-
> Daud�<[email protected]>
> > The next 10 patches add the remaining instructions for the Hexagon
> > scalar core
> >
> > The patches are logically independent but are organized as a series to
> > avoid potential conflicts if they are merged out of order.
> >
> > Note that the new test cases require an updated toolchain/container.
>
> https://gitlab.com/rth7680/qemu/-/jobs/1216248227
>
> The clang-user job errors out with
>
>
> > ../target/hexagon/genptr.c:31:20: error: unused function 'gen_read_reg' [-
> Werror,-Wunused-function]
> > static inline TCGv gen_read_reg(TCGv result, int num)
> > ^
> > ../target/hexagon/genptr.c:322:20: error: unused function 'gen_set_byte'
> [-Werror,-Wunused-function]
> > static inline void gen_set_byte(int N, TCGv result, TCGv src)
> > ^
My apologies!
What's the value of $CONFIG_ARGS that is referenced here
$ if test -n "$TARGETS"; then ../configure --enable-werror --disable-docs
$CONFIGURE_ARGS --target-list="$TARGETS" ; else ../configure --enable-werror
--disable-docs $CONFIGURE_ARGS ; fi || { cat config.log
meson-logs/meson-log.txt && exit 1; }
When I configure with
../configure --enable-werror --cc=clang --disable-docs
--target-list=hexagon-linux-user
I get -Wno-unused-function added to the compiler command line, so I don't see
the error.
Both were introduced in patch 22/26. Should I fix this by respinning the
series or sending a single patch?
Taylor
