On Thu, Apr 22, 2021 at 06:11:13PM +0200, Vitaly Kuznetsov wrote:
> There is no need to have this special case: like all other Hyper-V
> enlightenments we can just use kernel's supplied value in hv_passthrough
> mode.
Worth documenting this behaviour at docs/hyperv.txt? I was
expecting all properties set explicitly to override
hv-passthrough.
Reviewed-by: Eduardo Habkost <ehabk...@redhat.com>
>
> Signed-off-by: Vitaly Kuznetsov <vkuzn...@redhat.com>
> ---
> target/i386/kvm/kvm.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index ab073a5e9c44..afd173514da1 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -1256,11 +1256,7 @@ static int hyperv_handle_properties(CPUState *cs,
> c = cpuid_find_entry(cpuid, HV_CPUID_ENLIGHTMENT_INFO, 0);
> if (c) {
> env->features[FEAT_HV_RECOMM_EAX] = c->eax;
> -
> - /* hv-spinlocks may have been overriden */
> - if (cpu->hyperv_spinlock_attempts !=
> HYPERV_SPINLOCK_NEVER_NOTIFY) {
> - c->ebx = cpu->hyperv_spinlock_attempts;
> - }
> + cpu->hyperv_spinlock_attempts = c->ebx;
> }
> c = cpuid_find_entry(cpuid, HV_CPUID_NESTED_FEATURES, 0);
> if (c) {
> --
> 2.30.2
>
--
Eduardo
