03.05.2021 18:52, Alberto Garcia wrote:
On Mon 03 May 2021 01:33:58 PM CEST, Vladimir Sementsov-Ogievskiy 
<vsement...@virtuozzo.com> wrote:
We have one path, where tran object is created, but we don't touch and
don't free it in any way: "goto cleanup" in first loop with calls to
bdrv_flush().

Fix it simply moving tran_new() call below that loop.

Reported-by: Coverity (CID 1452772)
Reported-by: Peter Maydell <peter.mayd...@linaro.org>
Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
Fixes: 72373e40fbc7e4218061a8211384db362d3e7348
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>

Reviewed-by: Alberto Garcia <be...@igalia.com>


Thanks!  Still, now I see that Kevin's patch is better ([PATCH 2/2] block: Fix 
Transaction leak in bdrv_reopen_multiple())


--
Best regards,
Vladimir

Reply via email to