Philippe Mathieu-Daudé <phi...@redhat.com> writes:
> On 5/6/21 2:01 PM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé <phi...@redhat.com> writes: >> >>> GdbCmdParseEntry should have enough room with 20 chars for the command >>> string, and 8 for the schema. Add the GDB_CMD_PARSE_ENTRY_CMD_SIZE and >>> GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE definitions. >>> >>> Do not use pointer to string of unknown length, but array of fixed >>> size. Having constant size will help use to remove the alloca() call >>> in process_string_cmd() in the next commit. >> >> I don't understand how this helps. The alloca is being used for an array >> of GdbCmdVariant so why do we want to enlarge the size of the parse >> table entries? > > This patch is crap indeed. I'll post another one with more sense. Looking at the logic I wonder it's just better turning params into a GArray and let glib deal with the sizing for us? It's not like one or two entries breaks the bank on temporary memory allocation. > > Sorry about this, > > Phil. -- Alex Bennée
