Patchew URL: https://patchew.org/QEMU/20210508014802.892561-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210508014802.892561-1-richard.hender...@linaro.org Subject: [PATCH 00/72] Convert floatx80 and float128 to FloatParts === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210508014802.892561-1-richard.hender...@linaro.org -> patchew/20210508014802.892561-1-richard.hender...@linaro.org Switched to a new branch 'test' 2dcaa72 softfloat: Convert modrem operations to FloatParts 2956f6c softfloat: Move floatN_log2 to softfloat-parts.c.inc b786038 softfloat: Convert float32_exp2 to FloatParts 01ab7b4 softfloat: Convert floatx80 compare to FloatParts d55b655 softfloat: Convert floatx80_scalbn to FloatParts 0b1869b softfloat: Convert floatx80 to integer to FloatParts 6287e68 softfloat: Convert floatx80 float conversions to FloatParts 5c28030 softfloat: Convert integer to floatx80 to FloatParts e686e7d softfloat: Convert floatx80_round_to_int to FloatParts 9e7a606 softfloat: Convert floatx80_round to FloatParts d19c872 softfloat: Convert floatx80_sqrt to FloatParts 06addff softfloat: Convert floatx80_div to FloatParts 6974166 softfloat: Convert floatx80_mul to FloatParts 0ab65d7 softfloat: Convert floatx80_add/sub to FloatParts 5ae98cd tests/fp/fp-test: Reverse order of floatx80 precision tests dc5eada softfloat: Adjust parts_uncanon_normal for floatx80 0f4d3ce softfloat: Introduce Floatx80RoundPrec aecc38b softfloat: Reduce FloatFmt d8342e2 softfloat: Split out parts_uncanon_normal e8a3234 softfloat: Move sqrt_float to softfloat-parts.c.inc db066f3 softfloat: Move scalbn_decomposed to softfloat-parts.c.inc 870c56c softfloat: Move compare_floats to softfloat-parts.c.inc 4895586 softfloat: Move minmax_flags to softfloat-parts.c.inc c9e01de softfloat: Move uint_to_float to softfloat-parts.c.inc 0b58632 softfloat: Move int_to_float to softfloat-parts.c.inc e408986 softfloat: Move rount_to_uint_and_pack to softfloat-parts.c.inc 1330f41 softfloat: Move rount_to_int_and_pack to softfloat-parts.c.inc 2d631f0 softfloat: Move round_to_int to softfloat-parts.c.inc 45abdca softfloat: Convert float-to-float conversions with float128 0ddbdfd softfloat: Split float_to_float 296ad69 softfloat: Move div_floats to softfloat-parts.c.inc d5ff786 softfloat: Introduce sh[lr]_double primitives d227707 softfloat: Tidy mul128By64To192 5a9c124 softfloat: Use add192 in mul128To256 86d8505 softfloat: Use mulu64 for mul64To128 1186174 softfloat: Move muladd_floats to softfloat-parts.c.inc 5e4de79 softfloat: Move mul_floats to softfloat-parts.c.inc 1450eec softfloat: Implement float128_add/sub via parts ed27dea softfloat: Move addsub_floats to softfloat-parts.c.inc 3fe4a87 softfloat: Use uadd64_carry, usub64_borrow in softfloat-macros.h 5687e8b softfloat: Move round_canonical to softfloat-parts.c.inc ddf7181 softfloat: Move sf_canonicalize to softfloat-parts.c.inc 49b211c softfloat: Move pick_nan_muladd to softfloat-parts.c.inc d6fae5a softfloat: Move pick_nan to softfloat-parts.c.inc ada8c0f softfloat: Move return_nan to softfloat-parts.c.inc 701d4e6 softfloat: Convert float128_default_nan to parts 735bd6f softfloat: Convert float128_silence_nan to parts be031db softfloat: Rearrange FloatParts64 997cce0 softfloat: Use pointers with parts_silence_nan 759543e softfloat: Use pointers with ftype_round_pack_canonical 59155e0 softfloat: Use pointers with ftype_unpack_canonical 67f866d softfloat: Use pointers with ftype_pack_raw ad2e600 softfloat: Use pointers with pack_raw 6725bec softfloat: Use pointers with ftype_unpack_raw 6fa54f0 softfloat: Use pointers with unpack_raw 36916c3 softfloat: Use pointers with parts_default_nan e255c56 softfloat: Move type-specific pack/unpack routines 17cab05 softfloat: Rename FloatParts to FloatParts64 7973d6d softfloat: Do not produce a default_nan from parts_silence_nan 7267830 target/mips: Set set_default_nan_mode with set_snan_bit_is_one 8acc1a9 softfloat: fix return_nan vs default_nan_mode 5c700cd softfloat: Use return_nan in float_to_float e6a00e2 softfloat: Add float_cmask and constants 689fe83 softfloat: Tidy a * b + inf return 75285a4 softfloat: Use float_raise in more places a8ea262 softfloat: Inline float_raise 3be68a5 softfloat: Move the binary point to the msb e2236e1 tests/fp: add quad support to the benchmark utility be7703a accel/tcg: Use add/sub overflow routines in tcg-runtime-gvec.c 3731829 qemu/host-utils: Add wrappers for carry builtins a1367bc qemu/host-utils: Add wrappers for overflow builtins 96efc5c qemu/host-utils: Use __builtin_bitreverseN === OUTPUT BEGIN === 1/72 Checking commit 96efc5c8f4d0 (qemu/host-utils: Use __builtin_bitreverseN) WARNING: architecture specific defines should be avoided #24: FILE: include/qemu/host-utils.h:275: +#if __has_builtin(__builtin_bitreverse8) WARNING: architecture specific defines should be avoided #42: FILE: include/qemu/host-utils.h:296: +#if __has_builtin(__builtin_bitreverse16) WARNING: architecture specific defines should be avoided #60: FILE: include/qemu/host-utils.h:319: +#if __has_builtin(__builtin_bitreverse32) WARNING: architecture specific defines should be avoided #78: FILE: include/qemu/host-utils.h:342: +#if __has_builtin(__builtin_bitreverse64) total: 0 errors, 4 warnings, 64 lines checked Patch 1/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/72 Checking commit a1367bcd9ebb (qemu/host-utils: Add wrappers for overflow builtins) WARNING: architecture specific defines should be avoided #34: FILE: include/qemu/host-utils.h:369: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #52: FILE: include/qemu/host-utils.h:387: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #70: FILE: include/qemu/host-utils.h:405: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #88: FILE: include/qemu/host-utils.h:423: +#if __has_builtin(__builtin_add_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #107: FILE: include/qemu/host-utils.h:442: +#if __has_builtin(__builtin_sub_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #126: FILE: include/qemu/host-utils.h:461: +#if __has_builtin(__builtin_sub_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #145: FILE: include/qemu/host-utils.h:480: +#if __has_builtin(__builtin_sub_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #164: FILE: include/qemu/host-utils.h:499: +#if __has_builtin(__builtin_sub_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #182: FILE: include/qemu/host-utils.h:517: +#if __has_builtin(__builtin_mul_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #201: FILE: include/qemu/host-utils.h:536: +#if __has_builtin(__builtin_mul_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #221: FILE: include/qemu/host-utils.h:556: +#if __has_builtin(__builtin_mul_overflow) || __GNUC__ >= 5 WARNING: architecture specific defines should be avoided #240: FILE: include/qemu/host-utils.h:575: +#if __has_builtin(__builtin_mul_overflow) || __GNUC__ >= 5 total: 0 errors, 12 warnings, 231 lines checked Patch 2/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/72 Checking commit 37318292524c (qemu/host-utils: Add wrappers for carry builtins) WARNING: architecture specific defines should be avoided #43: FILE: include/qemu/host-utils.h:595: +#if __has_builtin(__builtin_addcll) WARNING: architecture specific defines should be avoided #68: FILE: include/qemu/host-utils.h:620: +#if __has_builtin(__builtin_subcll) total: 0 errors, 2 warnings, 62 lines checked Patch 3/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/72 Checking commit be7703ad3d1d (accel/tcg: Use add/sub overflow routines in tcg-runtime-gvec.c) 5/72 Checking commit e2236e18fc30 (tests/fp: add quad support to the benchmark utility) WARNING: line over 80 characters #182: FILE: tests/fp/fp-bench.c:458: + GEN_BENCH_NO_NEG(bench_ ## name ## _float128, float128, PREC_FLOAT128, op, n) WARNING: line over 80 characters #199: FILE: tests/fp/fp-bench.c:521: + fprintf(stderr, " -p = floating point precision (single, double, quad[soft only]). " total: 0 errors, 2 warnings, 185 lines checked Patch 5/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/72 Checking commit 3be68a54ecda (softfloat: Move the binary point to the msb) 7/72 Checking commit a8ea262fb400 (softfloat: Inline float_raise) 8/72 Checking commit 75285a4341ef (softfloat: Use float_raise in more places) 9/72 Checking commit 689fe83bcde1 (softfloat: Tidy a * b + inf return) 10/72 Checking commit e6a00e231540 (softfloat: Add float_cmask and constants) 11/72 Checking commit 5c700cd63df0 (softfloat: Use return_nan in float_to_float) 12/72 Checking commit 8acc1a959a15 (softfloat: fix return_nan vs default_nan_mode) 13/72 Checking commit 7267830dd66c (target/mips: Set set_default_nan_mode with set_snan_bit_is_one) 14/72 Checking commit 7973d6db759b (softfloat: Do not produce a default_nan from parts_silence_nan) 15/72 Checking commit 17cab0560556 (softfloat: Rename FloatParts to FloatParts64) WARNING: line over 80 characters #235: FILE: fpu/softfloat.c:928: +static FloatParts64 pick_nan_muladd(FloatParts64 a, FloatParts64 b, FloatParts64 c, WARNING: line over 80 characters #390: FILE: fpu/softfloat.c:1347: +static FloatParts64 muladd_floats(FloatParts64 a, FloatParts64 b, FloatParts64 c, WARNING: line over 80 characters #837: FILE: fpu/softfloat.c:3189: +static FloatRelation compare_floats(FloatParts64 a, FloatParts64 b, bool is_quiet, WARNING: Block comments use a leading /* on a separate line #875: FILE: fpu/softfloat.c:3374: + /* The largest float type (even though not supported by FloatParts64) WARNING: line over 80 characters #926: FILE: fpu/softfloat.c:3425: +static FloatParts64 sqrt_float(FloatParts64 a, float_status *s, const FloatFmt *p) total: 0 errors, 5 warnings, 1002 lines checked Patch 15/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/72 Checking commit e255c5631e4f (softfloat: Move type-specific pack/unpack routines) 17/72 Checking commit 36916c3edd6a (softfloat: Use pointers with parts_default_nan) 18/72 Checking commit 6fa54f0a9176 (softfloat: Use pointers with unpack_raw) 19/72 Checking commit 6725bec472d1 (softfloat: Use pointers with ftype_unpack_raw) 20/72 Checking commit ad2e6003ba80 (softfloat: Use pointers with pack_raw) 21/72 Checking commit 67f866dc3382 (softfloat: Use pointers with ftype_pack_raw) 22/72 Checking commit 59155e0623d2 (softfloat: Use pointers with ftype_unpack_canonical) 23/72 Checking commit 759543ead10f (softfloat: Use pointers with ftype_round_pack_canonical) 24/72 Checking commit 997cce09e9b5 (softfloat: Use pointers with parts_silence_nan) 25/72 Checking commit be031db06eb0 (softfloat: Rearrange FloatParts64) 26/72 Checking commit 735bd6fba22f (softfloat: Convert float128_silence_nan to parts) 27/72 Checking commit 701d4e63d467 (softfloat: Convert float128_default_nan to parts) 28/72 Checking commit ada8c0fd97c8 (softfloat: Move return_nan to softfloat-parts.c.inc) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #18: new file mode 100644 total: 0 errors, 1 warnings, 124 lines checked Patch 28/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/72 Checking commit d6fae5a986f6 (softfloat: Move pick_nan to softfloat-parts.c.inc) 30/72 Checking commit 49b211c61f33 (softfloat: Move pick_nan_muladd to softfloat-parts.c.inc) 31/72 Checking commit ddf7181b7486 (softfloat: Move sf_canonicalize to softfloat-parts.c.inc) 32/72 Checking commit 5687e8bdf817 (softfloat: Move round_canonical to softfloat-parts.c.inc) 33/72 Checking commit 3fe4a87f6fd6 (softfloat: Use uadd64_carry, usub64_borrow in softfloat-macros.h) 34/72 Checking commit ed27dea74977 (softfloat: Move addsub_floats to softfloat-parts.c.inc) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #19: new file mode 100644 ERROR: space required after that ',' (ctx:VxV) #270: FILE: fpu/softfloat.c:957: +#define partsN(NAME) glue(glue(glue(parts,N),_),NAME) ^ ERROR: space required after that ',' (ctx:VxV) #270: FILE: fpu/softfloat.c:957: +#define partsN(NAME) glue(glue(glue(parts,N),_),NAME) ^ ERROR: space required after that ',' (ctx:VxV) #270: FILE: fpu/softfloat.c:957: +#define partsN(NAME) glue(glue(glue(parts,N),_),NAME) ^ ERROR: space required after that ',' (ctx:VxV) #271: FILE: fpu/softfloat.c:958: +#define FloatPartsN glue(FloatParts,N) ^ total: 4 errors, 1 warnings, 489 lines checked Patch 34/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 35/72 Checking commit 1450eec1d1a9 (softfloat: Implement float128_add/sub via parts) 36/72 Checking commit 5e4de79a96ed (softfloat: Move mul_floats to softfloat-parts.c.inc) ERROR: space required after that ',' (ctx:VxV) #151: FILE: fpu/softfloat.c:1003: +#define FloatPartsW glue(FloatParts,W) ^ total: 1 errors, 0 warnings, 350 lines checked Patch 36/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 37/72 Checking commit 11861744634d (softfloat: Move muladd_floats to softfloat-parts.c.inc) 38/72 Checking commit 86d850509935 (softfloat: Use mulu64 for mul64To128) 39/72 Checking commit 5a9c12452902 (softfloat: Use add192 in mul128To256) ERROR: space prohibited after that open parenthesis '(' #61: FILE: include/fpu/softfloat-macros.h:527: + add192( 0, m1, m2, 0, n1, n2, &m0, &m1, &m2); total: 1 errors, 0 warnings, 46 lines checked Patch 39/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/72 Checking commit d22770700ad7 (softfloat: Tidy mul128By64To192) 41/72 Checking commit d5ff7869a46b (softfloat: Introduce sh[lr]_double primitives) WARNING: architecture specific defines should be avoided #203: FILE: include/fpu/softfloat-macros.h:98: +#if defined(__x86_64__) WARNING: architecture specific defines should be avoided #221: FILE: include/fpu/softfloat-macros.h:116: +#if defined(__x86_64__) total: 0 errors, 2 warnings, 199 lines checked Patch 41/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 42/72 Checking commit 296ad691084d (softfloat: Move div_floats to softfloat-parts.c.inc) 43/72 Checking commit 0ddbdfdd1a7c (softfloat: Split float_to_float) 44/72 Checking commit 45abdcae4504 (softfloat: Convert float-to-float conversions with float128) 45/72 Checking commit 2d631f07b19f (softfloat: Move round_to_int to softfloat-parts.c.inc) 46/72 Checking commit 1330f41e01bb (softfloat: Move rount_to_int_and_pack to softfloat-parts.c.inc) 47/72 Checking commit e408986129be (softfloat: Move rount_to_uint_and_pack to softfloat-parts.c.inc) 48/72 Checking commit 0b586325bf5a (softfloat: Move int_to_float to softfloat-parts.c.inc) 49/72 Checking commit c9e01de1b349 (softfloat: Move uint_to_float to softfloat-parts.c.inc) 50/72 Checking commit 4895586cb8dc (softfloat: Move minmax_flags to softfloat-parts.c.inc) 51/72 Checking commit 870c56c4e127 (softfloat: Move compare_floats to softfloat-parts.c.inc) 52/72 Checking commit db066f333726 (softfloat: Move scalbn_decomposed to softfloat-parts.c.inc) 53/72 Checking commit e8a323470fbf (softfloat: Move sqrt_float to softfloat-parts.c.inc) 54/72 Checking commit d8342e21ffda (softfloat: Split out parts_uncanon_normal) 55/72 Checking commit aecc38becfb6 (softfloat: Reduce FloatFmt) 56/72 Checking commit 0f4d3ce1b908 (softfloat: Introduce Floatx80RoundPrec) 57/72 Checking commit dc5eada61c8f (softfloat: Adjust parts_uncanon_normal for floatx80) 58/72 Checking commit 5ae98cd1dd64 (tests/fp/fp-test: Reverse order of floatx80 precision tests) 59/72 Checking commit 0ab65d7f28d9 (softfloat: Convert floatx80_add/sub to FloatParts) 60/72 Checking commit 6974166c3993 (softfloat: Convert floatx80_mul to FloatParts) 61/72 Checking commit 06addffabfe9 (softfloat: Convert floatx80_div to FloatParts) 62/72 Checking commit d19c872604c3 (softfloat: Convert floatx80_sqrt to FloatParts) 63/72 Checking commit 9e7a60645c6d (softfloat: Convert floatx80_round to FloatParts) 64/72 Checking commit e686e7da3302 (softfloat: Convert floatx80_round_to_int to FloatParts) 65/72 Checking commit 5c28030e4ea5 (softfloat: Convert integer to floatx80 to FloatParts) 66/72 Checking commit 6287e685faf8 (softfloat: Convert floatx80 float conversions to FloatParts) 67/72 Checking commit 0b1869b8f8b3 (softfloat: Convert floatx80 to integer to FloatParts) 68/72 Checking commit d55b65538352 (softfloat: Convert floatx80_scalbn to FloatParts) 69/72 Checking commit 01ab7b4aed96 (softfloat: Convert floatx80 compare to FloatParts) 70/72 Checking commit b78603823353 (softfloat: Convert float32_exp2 to FloatParts) 71/72 Checking commit 2956f6c7c5d3 (softfloat: Move floatN_log2 to softfloat-parts.c.inc) Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #325: new file mode 100644 ERROR: trailing whitespace #376: FILE: tests/fp/fp-test-log2.c:47: + $ total: 1 errors, 1 warnings, 410 lines checked Patch 71/72 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 72/72 Checking commit 2dcaa72f9b5e (softfloat: Convert modrem operations to FloatParts) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210508014802.892561-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com