From: Gustavo Noronha Silva <gust...@noronha.eti.br> v4 moves the code to add the tap to the set function, which not only sidesteps the issue pointed out by Akihiko Odaki but simply makes sense - full-grab is not a runtime toggle and there is no reason to have the tap set up if it's not turned on.
It also fixes the commit message for the swap-option-command option to no longer lie about it being turned on by default, as pointed out by Gerd. ----- This series adds two new options to the cocoa display: - full-grab causes it to use a global tap to steal system combos away from Mac OS X, so they can be handled by the VM - swap-option-command does what it says on the tin; while that is something you can do at the Mac OS X level or even supported by some keyboards, it is much more convenient to have qemu put Meta/Super and Alt where they belong if you are running a non-Mac VM Both are off by default. For full-grab in particular, it is off also because unfortunately it needs accessibility permissions for input grabbing, so it requires more deliberate action by the user anyway. Gustavo Noronha Silva (2): ui/cocoa: capture all keys and combos when mouse is grabbed ui/cocoa: add option to swap Option and Command qapi/ui.json | 22 +++++++++ qemu-options.hx | 4 ++ ui/cocoa.m | 129 ++++++++++++++++++++++++++++++++++++++++++++---- 3 files changed, 146 insertions(+), 9 deletions(-) -- 2.30.1 (Apple Git-130)
