Re: [RFC PATCH 17/25] hw/virtio: Use correct type sizes

[Richard Henderson]

On 5/18/21 1:36 PM, Philippe Mathieu-Daudé wrote:

-static inline int virtio_lduw_p(VirtIODevice *vdev, const void *ptr)
+static inline uint16_t virtio_lduw_p(VirtIODevice *vdev, const void *ptr)

While this one looks obviously correct,

-static inline int virtio_ldl_p(VirtIODevice *vdev, const void *ptr)
+static inline uint32_t virtio_ldl_p(VirtIODevice *vdev, const void *ptr)
  {
      if (virtio_access_is_big_endian(vdev)) {
          return ldl_be_p(ptr);

this one isn't so obvious.

Are all of the users unsigned?  If so, should we rename it ldul?


r~