On 6/4/21 8:52 AM, Alex Bennée wrote:
@@ -276,8 +276,8 @@ static void cpu_max_set_sve_max_vq(Object *obj, Visitor *v,
const char *name,
* of the contents of "name" to determine which bit on which
* to operate.
*/
-static void cpu_arm_get_sve_vq(Object *obj, Visitor *v, const char *name,
- void *opaque, Error **errp)
+static void get_prop_vq(Object *obj, Visitor *v, const char *name,
+ void *opaque, Error **errp)
The comment above this function needs some renames to match.
Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
diff --git a/target/arm/kvm/kvm-cpu.c b/target/arm/kvm/kvm-cpu.c
index a23831e3c6..09aede9319 100644
--- a/target/arm/kvm/kvm-cpu.c
+++ b/target/arm/kvm/kvm-cpu.c
@@ -89,7 +89,7 @@ static void host_cpu_instance_init(Object *obj)
kvm_arm_set_cpu_features_from_host(cpu);
if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
- aarch64_add_sve_properties(obj);
+ cpu_sve_add_props(obj);
As an aside, I think this if is always true. kvm is 64-bit only now. One can
start 32-bit guests, with proper host cpu support, but it's the "aarch64" cpu
property that controls this. And all cpu properties are processed all at once.
r~
