On 08/06/2021 15.42, John Snow wrote:
On 6/4/21 11:53 AM, Alex Bennée wrote:
The assumption that the qemu-system-aarch64 image can run all 32 bit
machines is about to be broken and besides it's not likely this is
What's changing? I'm not deeply familiar with aarch64. Why is this
assumption about to be broken?
That's also quite a surprise to me. Do you have any pointers?
improving out coverage by much. Test the "virt" machine for both arm
and aarch64 as it can be used by either architecture.
Sounds fine to me, but I didn't write this part of the test. Thomas, you
wrote this section IIRC -- does this reduce coverage in any meaningful way?
I think we built only aarch64 in a couple of our CI pipelines, assuming that
it covers all normal arm machines, too ... so we might want to revisit our
CI pipelines to check whether we then need more test coverage for
qemu-system-arm instead. But apart from that, the patch looks ok to me.
Thomas
