Hello Philippe, On Mon, Jun 21, 2021 at 8:28 PM Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> Hi Niteesh, > > On 6/16/21 5:48 PM, Niteesh G. S. wrote: > > Hello, > > > > We now have a reasonably working prototype that is capable of > > sending/receiving > > commands/responses, syntax highlighting, and a simple notification > > system. The > > prototype can be found here > > https://gitlab.com/niteesh.gs/qemu/-/tree/aqmp-tui-prototype > > <https://gitlab.com/niteesh.gs/qemu/-/tree/aqmp-tui-prototype> > > Working on this prototype gives us a lot of hints on things to worry > > about and other > > ideas that were worth implementing. Our next goal is to start working on > > the real TUI > > based on this prototype. > > > > One requested feature of the TUI was to show documentation for the > > commands typed. > > To achieve this, a QMP command that lets us query the documentation from > > QEMU has > > to be implemented and some discussion has already been done on it in a > > previous thread. > > I request all continue that discussion here and suggest ideas regarding > > implementation. > > The goal is to come up with something small and simple which can also be > > improved upon > > after the summer. > > > > I have a simple implementation of the command that returns dummy > > documentation here > > > https://gitlab.com/niteesh.gs/qemu/-/commit/796a41fb2840b9f3484c6fd5672e6fceb73acaef > > < > https://gitlab.com/niteesh.gs/qemu/-/commit/796a41fb2840b9f3484c6fd5672e6fceb73acaef > > > > I noticed your mail got no comment, and realized you asked us to > review your patches apart from the mailing list. I am not sure > if this is an experiment or a misunderstanding, but so far it is > unlikely you get review external to the mailing list, because it > is not very practical to reviewers. > Sorry for not conveying the main intent of this mail properly. The main goal of this mail was to start a discussion regarding the implementation of the QMP documentation retrieval command for AQMP TUI. There has already been a small discussion regarding it in my introduction mail but it wasn't anything in detail and it stagnated. So I created this mail to have a separate thread to collect all points regarding implementation and again start the discussion. We now have a prototype with the most basic features implemented and working. But there is a lot of clean-up that has to be done before I can send the prototype to the mailing list for review. And since the prototype is almost done John asked me to start a discussion regarding the QMP command so that I can work on it as a side project along side the TUI. TLDR: The goal of this mail wasn't to review the dummy command I had posted but rather start a discussion regarding the implementation of the QMP documentation retrieval command for the TUI. Thanks, Niteesh. > Maybe some reviewers are willing to look at your tree, but if you > are looking for a wider audience, I recommend you to follow this > process (which you already used!): > https://wiki.qemu.org/Contribute/SubmitAPatch#Submitting_your_Patches > > Regards, > > Phil. > >
