22.06.2021 14:04, Emanuele Giuseppe Esposito wrote:
On 22/06/2021 12:50, Vladimir Sementsov-Ogievskiy wrote:
21.06.2021 13:33, Emanuele Giuseppe Esposito wrote:
Attaching gdbserver implies that the qmp socket
should wait indefinitely for an answer from QEMU.
Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
Please, let this patch go without my r-b. I don't like it, I explained my
thoughts, and you even used my suggested way in previous version.
What I don't like: good component - Timeout class, which is currently
independent of outer code and can be simply moved to another module becomes
dependent on global variable, which doesn't relate to the class itself. Neither
I like logic of the dependency which just make the whole class do nothing by
skipping any action internally. So, IMHO Timeout class becomes worse.
I'm not a maintainer here anyway, so my r-b isn't necessary :)
Oh okay. Sorry I understood from previous versions that you liked it even
without your suggested change. Apologies.
No problem. I really gave an r-b to earlier version, so formally you had it
until now :) I thought I was explicit enough in my last comment to this patch
in v5. apologies if not(
--
Best regards,
Vladimir
