On Wed, Jun 23, 2021 at 05:00:16PM +0200, Stefano Garzarella wrote: > On Mon, Jun 21, 2021 at 12:16:38PM +0800, Jason Wang wrote: > > Fixes: 1e0a84ea49b68 ("vhost-vdpa: introduce vhost-vdpa net client") > > Signed-off-by: Jason Wang <jasow...@redhat.com> > > --- > > net/vhost-vdpa.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > > index f5689a7c32..21f09c546f 100644 > > --- a/net/vhost-vdpa.c > > +++ b/net/vhost-vdpa.c > > @@ -111,6 +111,7 @@ static int vhost_vdpa_add(NetClientState *ncs, void *be) > > err: > > if (net) { > > vhost_net_cleanup(net); > > + g_free(net);
Shouldn't this call be part of the implementation of vhost_net_cleanup()? > > } > > return -1; > > } > > -- > > 2.25.1 > > > > > > Reviewed-by: Stefano Garzarella <sgarz...@redhat.com> >