On Fri, Apr 02, 2021 at 09:02:54AM -0700, Akihiko Odaki wrote: > This commit introduces "punch hole" operation and optimizes transfer > block size for macOS. > > Thanks to Konstantin Nazarov for detailed analysis of a flaw in an > old version of this change: > https://gist.github.com/akihikodaki/87df4149e7ca87f18dc56807ec5a1bc5#gistcomment-3654667 > > Signed-off-by: Akihiko Odaki <akihiko.od...@gmail.com> > --- > block/file-posix.c | 27 +++++++++++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-)
I encountered the following qemu-iotests failure after applying this
series:
172 fail [11:09:32] [11:09:36] 3.6s
output mismatch (see 172.out.bad)
--- /home/stefanha/qemu/tests/qemu-iotests/172.out
+++ 172.out.bad
@@ -21,6 +21,7 @@
dev: floppy, id ""
unit = 0 (0x0)
drive = "floppy0"
+ backend_defaults = "auto"
logical_block_size = 512 (512 B)
physical_block_size = 512 (512 B)
min_io_size = 0 (0 B)
...
You can run the test case like this:
$ (cd tests/qemu-iotests && ./check -qcow2 172)
It looks like the 172.out test output file just needs to be updated to
include the new backend_defaults property.
Stefan
signature.asc
Description: PGP signature
