On 7/5/21 12:42 PM, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> This avoids failing to initialize virgl and crashing later on, and clear
> the user expectations.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> hw/display/virtio-gpu-gl.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c
> index aea9700d5c..bc55c4767e 100644
> --- a/hw/display/virtio-gpu-gl.c
> +++ b/hw/display/virtio-gpu-gl.c
> @@ -113,6 +113,11 @@ static void virtio_gpu_gl_device_realize(DeviceState
> *qdev, Error **errp)
> return;
> #endif
>
> + if (!object_resolve_path_type("", TYPE_VIRTIO_GPU_GL, NULL)) {
Isn't the condition inverted?
> + error_setg(errp, "at most one %s device is permitted",
> TYPE_VIRTIO_GPU_GL);
> + return;
> + }
> +
> if (!display_opengl) {
> error_setg(errp, "opengl is not available");
> return;
>
