On Thu, 2021-07-08 at 19:20 +0200, Cornelia Huck wrote:
> On Wed, Jul 07 2021, "Cho, Yu-Chen" <[email protected]> wrote:
>
> > the lack of target_user_arch makes it hard to fully leverage the
> > build system in order to separate user code from sysemu code.
> >
> > Provide it, so that we can avoid the proliferation of #ifdef
> > in target code.
> >
> > Signed-off-by: Claudio Fontana <[email protected]>
> > Signed-off-by: Cho, Yu-Chen <[email protected]>
>
> Just noticed when I was sending a pull request: your unquoted name in
> the s-o-b confuses git send-email when it is doing its automatic cc:s
> (it adds a 'cc:Cho', which is obviously bogus and leads to the mail
> being rejected by the list server.) Not sure whether git send-email
> should add proper quoting itself, but putting quoting in the s-o-b
> line
> is probably a good idea (I'm wondering why git didn't add it in the
> first place.)
>
Not sure what happened here, but I didn't get any wrong from git send-
email before.
> Are you fine with me modifying your s-o-b lines in the commits to
> include quoting, if I need to resend the pull req?
>
yes, please and thanks.
Cheers,
AL
> > Acked-by: Cornelia Huck <[email protected]>
> > Reviewed-by: Richard Henderson <[email protected]>
> > ---
> > target/s390x/meson.build | 3 +++
> > 1 file changed, 3 insertions(+)
>
