13.07.2021 00:55, Richard Henderson wrote:
From clang-13: nbd/server.c:976:22: error: variable 'bitmaps' set but not used \ [-Werror,-Wunused-but-set-variable]Cc: qemu-bl...@nongnu.org Cc: Eric Blake <ebl...@redhat.com> Cc: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Signed-off-by: Richard Henderson <richard.hender...@linaro.org> --- nbd/server.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index b60ebc3ab6..721349ec00 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -973,7 +973,6 @@ static int nbd_negotiate_meta_queries(NBDClient *client, { int ret; g_autofree char *export_name = NULL; - g_autofree bool *bitmaps = NULL; NBDExportMetaContexts local_meta = {0}; uint32_t nb_queries; size_t i; @@ -1007,9 +1006,6 @@ static int nbd_negotiate_meta_queries(NBDClient *client, "export '%s' not present", sane_name); } meta->bitmaps = g_new0(bool, meta->exp->nr_export_bitmaps); - if (client->opt == NBD_OPT_LIST_META_CONTEXT) { - bitmaps = meta->bitmaps; - }ret = nbd_opt_read(client, &nb_queries, sizeof(nb_queries), false, errp);if (ret <= 0) {
Hm. I'm afraid, this way meta->bitmaps will be leaked in NBD_OPT_LIST_META_CONTEXT case. Actually, "bitmaps" _is_ used, in cleanup handler, setup by g_autofree. So it's a false positive. -- Best regards, Vladimir
