Re: [PATCH for-6.2 06/34] target/arm: Fix 48-bit saturating shifts

[Peter Maydell]

On Fri, 16 Jul 2021 at 17:34, Richard Henderson
<richard.hender...@linaro.org> wrote:
>
> On 7/13/21 6:36 AM, Peter Maydell wrote:
> > -    return (1ULL << 47) - (src >= 0);
> > +    return sextract64((1ULL << 47) - (src >= 0), 0, 48);
>
> Clearer as
>
>    return src >= 0 ? MAKE_64BIT_MASK(0, 47) : MAKE_64BIT_MASK(47, 17);

Yeah, agreed.

thanks
-- PMM