On Sun, Jul 18, 2021 at 10:39:16PM +0200, BALATON Zoltan wrote: > On Sun, 18 Jul 2021, Corey Minyard wrote: > > On Thu, Jul 15, 2021 at 06:50:44PM +0200, BALATON Zoltan wrote: > > > Add the differential clock input feature bit to the generated SPD > > > data. Most guests don't seem to care but pegasos2 firmware version 1.2 > > > checks for this bit and stops with unsupported module type error if > > > it's not present. Since this feature is likely present on real memory > > > modules add it in the general code rather than patching the generated > > > SPD data in pegasos2 board only. > > > > > > Signed-off-by: BALATON Zoltan <bala...@eik.bme.hu> > > > > I checked this all out and it looks correct to me. I can take it in my > > tree, if necessary. Feature freeze is in two days, so probably not for > > 6.1, though it could be pushed into there if its needed in 6.1. > > > > Or: > > > > Acked-by: Corey Minyard <cminy...@mvista.com> > > Thanks. As this fixes pegasos2 ROM 1.2 that some users may find instead of > the 1.1 version I consider this a bugfix not a feature and would like to get > merged for 6.1 if possible (hopefully can be in David's tree with the other > patch that's also a bugfix) because that way it won't happen that some users > will get problems if they find the wrong ROM. With this patch both versions > available on line work so there should be no problem for anyone. Other > firmware ROMs don't seem to care so they're unlikely to break and the only > machines using it now are pegasos2, sam460ex and fuloong2e and only when > using firmware ROM so this does not need to wait until 6.2 I think as 6.1 is > the first version pegasos2 is available and it would be nice to get it > working well in the first version.
I'll accept the argument that this is a bugfix, and reasonable to
merge at least early in the freeze. So, I've merged it into my tree
with Corey's ack.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
