On 21/07/2021 10:58, Igor Mammedov wrote: > On Tue, 20 Jul 2021 20:16:44 +0200 > Laurent Vivier <lviv...@redhat.com> wrote: > >> This simple change allows to test failover with a simulated device >> like e1000e rather than a vfio device. >> >> This is interesting to developers that want to test failover on >> a system with no vfio device. Moreover it simplifies host networking >> configuration as we can use the same bridge for virtio-net and >> the other failover networking device. >> >> Without this change the migration of a system configured with failover >> fails with: >> >> Unknown ramblock "0000:00:01.1:00.0/e1000e.rom", cannot accept migration >> error while loading state for instance 0x0 of device 'ram' >> load of migration failed: Invalid argument >> >> Signed-off-by: Laurent Vivier <lviv...@redhat.com> > > Reviewed-by: Igor Mammedov <imamm...@redhat.com> >
I've sent a v2 of this patch to reset has_rom to false. I've updated the commit log message and the subject of the email to "failover: unregister ROM on unplug" (that is more correct). Thanks, Laurent
