On Mon, Jul 26, 2021 at 10:08:59AM +0200, David Hildenbrand wrote:
> diff --git a/hw/tpm/tpm_ppi.c b/hw/tpm/tpm_ppi.c
> index 362edcc5c9..fab49524d7 100644
> --- a/hw/tpm/tpm_ppi.c
> +++ b/hw/tpm/tpm_ppi.c
> @@ -30,11 +30,14 @@ void tpm_ppi_reset(TPMPPI *tpmppi)
> guest_phys_blocks_init(&guest_phys_blocks);
> guest_phys_blocks_append(&guest_phys_blocks);
> QTAILQ_FOREACH(block, &guest_phys_blocks.head, next) {
> + hwaddr mr_offs = (uint8_t *)
> memory_region_get_ram_ptr(block->mr) -
> + block->host_addr;
> +
> trace_tpm_ppi_memset(block->host_addr,
> block->target_end - block->target_start);
> memset(block->host_addr, 0,
> block->target_end - block->target_start);
> - memory_region_set_dirty(block->mr, 0,
> + memory_region_set_dirty(block->mr, mr_offs,
> block->target_end - block->target_start);
> }
> guest_phys_blocks_free(&guest_phys_blocks);
>
>
> That should make more sense :)
Yep, looks good to me (and simpler!).
--
Peter Xu
