On Sun, Jul 25, 2021 at 02:24:10AM -1000, Richard Henderson wrote: > From clang-13: > util/selfmap.c:26:21: error: variable 'errors' set but not used \ > [-Werror,-Wunused-but-set-variable] > > Quite right of course, but there's no reason not to check errors. > > First, incrementing errors is incorrect, because qemu_strtoul > returns an errno not a count -- just or them together so that > we have a non-zero value at the end. > > Second, if we have an error, do not add the struct to the list, > but free it instead. > > Cc: Alex Bennée <alex.ben...@linaro.org> > Signed-off-by: Richard Henderson <richard.hender...@linaro.org> > --- > util/selfmap.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
