On Thu, 29 Jul 2021 at 19:03, Eduardo Habkost <ehabk...@redhat.com> wrote: > > The OBJECT_DECLARE_SIMPLE_TYPE documentation was inaccurate: it > doesn't define a class struct or class type checking helpers. > > OBJECT_DECLARE_TYPE expansion looks very similar to the existing > example, though. Rewrite that section to show both both > OBJECT_DECLARE_SIMPLE_TYPE and OBJECT_DECLARE_TYPE. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > docs/devel/qom.rst | 31 +++++++++++++++++++++---------- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/docs/devel/qom.rst b/docs/devel/qom.rst > index dee60a64c0a..aa1f672efbe 100644 > --- a/docs/devel/qom.rst > +++ b/docs/devel/qom.rst > @@ -301,6 +301,27 @@ This is equivalent to the following: > .. code-block:: c > :caption: Expansion from declaring a simple type > > + typedef struct MyDevice MyDevice; > + G_DEFINE_AUTOPTR_CLEANUP_FUNC(MyDevice, object_unref) > + #define MY_DEVICE(void *obj) > + OBJECT_CHECK(MyDevice, obj, TYPE_MY_DEVICE) >
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> though I note that the macro doesn't actually create a MY_DEVICE #define any more -- you get a function named MY_DEVICE(). I guess "equivalent to" covers that. thanks -- PMM