On Wed, Aug 04, 2021 at 12:31:05PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Change the 'if' condition strings to be C-agnostic. It will accept > '[A-Z][A-Z0-9_]*' identifiers. This allows to express configuration
This allows the expression of configuration > conditions in other languages (Rust or Python for ex) or other more I'd spell out 'example' > suitable forms. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com> > Tested-by: John Snow <js...@redhat.com> > --- > @@ -4307,8 +4307,8 @@ > # @size: Size of the virtual disk in bytes > # @preallocation: Preallocation mode for the new image (default: off; > # allowed values: off, > -# falloc (if defined CONFIG_POSIX_FALLOCATE), > -# full (if defined CONFIG_POSIX)) > +# falloc (if CONFIG_POSIX_FALLOCATE), > +# full (if CONFIG_POSIX)) Pre-existing, but the (double (nesting)) is a bit lisp-y considering this comment is user-facing, where using [] for one of the layers might help readability. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
