On 10/08/2021 18.44, Daniel P. Berrangé wrote:
The 'check-build' make target was added as a way to build all the unit test binaries, since the standard 'all' target would not trigger this.Since the switch to meson, however, 'all' will now include the 'test' binaries. As a result, 'check-build' is a no-op: $ make all check-build ..snip lots of output... make: Nothing to be done for 'check-build'.
I think it would be better to restore the previous behaviour, so that "all" does not build the test files by default. Most normal users don't need the tests, so compiling them by default wastes precious CPU cycles.
See also: https://lore.kernel.org/qemu-devel/8d5714d1-d92b-60fc-531f-73eb05852...@gmail.com/ https://lore.kernel.org/qemu-devel/472c9809-8987-3c2c-c2b5-b99d637ac...@redhat.com/ Thomas
