On Thu, 12 Aug 2021 at 12:11, Dr. David Alan Gilbert (git) <dgilb...@redhat.com> wrote: > > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > ShellCheck points out that tr '[a-z]' actually replaces the []'s > and only the a-z is needed. > > Remove the spurious [] - although in this use it will make no > difference. > > Fixes: bb55b712e8dc4d4eb515144d5c26798fea178cba > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 9a79a004d7..5bb8c2a59d 100755 > --- a/configure > +++ b/configure > @@ -4549,7 +4549,7 @@ if test "$gprof" = "yes" ; then > fi > echo "CONFIG_AUDIO_DRIVERS=$audio_drv_list" >> $config_host_mak > for drv in $audio_drv_list; do > - def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr '[a-z]' '[A-Z]') > + def=CONFIG_AUDIO_$(echo $drv | LC_ALL=C tr 'a-z' 'A-Z') > echo "$def=y" >> $config_host_mak > done > if test "$alsa" = "yes" ; then > -
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> (Is this the only thing shellcheck complains about in configure? I'm guessing not...) thanks -- PMM