On 8/17/21 10:56 AM, Michal Privoznik wrote: > If a chardev has a logfile the file is opened using > qemu_open_old() which does the job, but since @errp is not > propagated into qemu_open_internal() we lose much more accurate > error and just report "Unable to open logfile $errno". When > using plain files, it's probably okay as nothing complex is > happening behind the curtains. But the problem becomes more > prominent when passing an "/dev/fdset/XXX" path since much more > needs to be done. > > The fix is to use qemu_create() which passes @errp further down. > > Signed-off-by: Michal Privoznik <mpriv...@redhat.com> > --- > chardev/char.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
