On Sat, 14 Aug 2021 at 00:34, Hao Wu <wuhao...@google.com> wrote:
>
> From: Patrick Venture <vent...@google.com>
>
> Adds supported i2c devices to the quanta-gbc-bmc board.
>
> Signed-off-by: Patrick Venture <vent...@google.com>
> Reviewed-by: Hao Wu <wuhao...@google.com>
> ---
> hw/arm/npcm7xx_boards.c | 79 +++++++++++++++++++++++------------------
> 1 file changed, 45 insertions(+), 34 deletions(-)
>
Does the documentation need updating to mention these newly supported devices ?
> static void quanta_gbs_i2c_init(NPCM7xxState *soc)
> {
> - /*
> - * i2c-0:
> - * pca9546@71
> - *
> - * i2c-1:
> + I2CSlave *i2c_mux;
> +
> + /* i2c-0: */
> + i2c_slave_create_simple(npcm7xx_i2c_get_bus(soc, 0), TYPE_PCA9546, 0x71);
> +
> + /* i2c-1:
> * pca9535@24
> * pca9535@20
> * pca9535@21
This leaves this multiline block comment with the wrong format: QEMU's
coding style wants the leading "/*" on a line of its own. Similarly
for some others in this patch.
thanks
-- PMM
