On Tue, Aug 10, 2021 at 11:22:27AM +0200, Igor Mammedov wrote: > On Tue, 10 Aug 2021 10:45:02 +0200 > Jean-Philippe Brucker <jean-phili...@linaro.org> wrote: > > > Add a function that generates a Virtual I/O Translation table (VIOT), > > describing the topology of paravirtual IOMMUs. The table is created when > > instantiating a virtio-iommu device. It contains a virtio-iommu node and > > PCI Range nodes for endpoints managed by the IOMMU. By default, a single > > node describes all PCI devices. When passing the "default_bus_bypass_iommu" > > machine option and "bypass_iommu" PXB option, only buses that do not > > bypass the IOMMU are described by PCI Range nodes. > > > > Signed-off-by: Jean-Philippe Brucker <jean-phili...@linaro.org> > > > using packed structures for composing ACPI tables is discouraged, > pls use build_append_int_noprefix() API instead. You can look at > build_amd_iommu() as an example. > > PS: > Also note field comments format. > /it should be verbatim copy of entry name from respective table in spec/
Got it, I'll switch to build_append_int_noprefix() Thanks, Jean