Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- include/exec/exec-all.h | 3 +-- include/tcg/tcg-module.h | 2 ++ accel/tcg/tcg-module.c | 5 +++++ accel/tcg/translate-all.c | 3 ++- cpu.c | 4 ++-- linux-user/mmap.c | 6 +++--- softmmu/physmem.c | 2 +- 7 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 9cb8337acee1..c27e911b65f9 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -25,7 +25,6 @@ #include "exec/cpu_ldst.h" #endif #include "sysemu/cpu-timers.h" -#include "tcg/tcg-module.h" /* allow to see translation results - the slowdown should be negligible, so we leave it */ #define DEBUG_DISAS @@ -42,6 +41,7 @@ typedef ram_addr_t tb_page_addr_t; #endif #include "qemu/log.h" +#include "tcg/tcg-module.h" void gen_intermediate_code(CPUState *cpu, TranslationBlock *tb, int max_insns); void restore_state_to_opc(CPUArchState *env, TranslationBlock *tb, @@ -571,7 +571,6 @@ void tb_invalidate_phys_addr(tb_page_addr_t addr); #else void tb_invalidate_phys_addr(AddressSpace *as, hwaddr addr, MemTxAttrs attrs); #endif -void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end); void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); TranslationBlock *tb_htable_lookup(CPUState *cpu, target_ulong pc, target_ulong cs_base, uint32_t flags, diff --git a/include/tcg/tcg-module.h b/include/tcg/tcg-module.h index 003581b0718c..6069b056f91f 100644 --- a/include/tcg/tcg-module.h +++ b/include/tcg/tcg-module.h @@ -14,6 +14,8 @@ struct TCGModuleOps { void (*tcg_exec_unrealizefn)(CPUState *cpu); void (*tcg_exec_realizefn)(CPUState *cpu, Error **errp); void (*tb_flush)(CPUState *cpu); + void (*tb_invalidate_phys_range)(tb_page_addr_t start, tb_page_addr_t end); + }; extern struct TCGModuleOps tcg; diff --git a/accel/tcg/tcg-module.c b/accel/tcg/tcg-module.c index 7600951fd20b..dfd7d3bbc2e0 100644 --- a/accel/tcg/tcg-module.c +++ b/accel/tcg/tcg-module.c @@ -25,6 +25,10 @@ static void tcg_exec_realizefn_stub(CPUState *cpu, Error **errp) { } +static void tb_invalidate_phys_range_stub(tb_page_addr_t start, tb_page_addr_t end) +{ +} + struct TCGModuleOps tcg = { .tlb_flush = update_cpu_stub, .tlb_flush_page = tlb_flush_page_stub, @@ -35,4 +39,5 @@ struct TCGModuleOps tcg = { .tcg_exec_realizefn = tcg_exec_realizefn_stub, .tcg_exec_unrealizefn = update_cpu_stub, .tb_flush = update_cpu_stub, + .tb_invalidate_phys_range = tb_invalidate_phys_range_stub, }; diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 3a3a60575141..e71e58aff9e7 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -1777,7 +1777,7 @@ tb_invalidate_phys_page_range__locked(struct page_collection *pages, * * Called with mmap_lock held for user-mode emulation. */ -void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end) +static void tb_invalidate_phys_range(tb_page_addr_t start, tb_page_addr_t end) { struct page_collection *pages; tb_page_addr_t next; @@ -2438,6 +2438,7 @@ int page_unprotect(target_ulong address, uintptr_t pc) static void tcg_module_ops_tb(void) { tcg.tb_flush = tb_flush; + tcg.tb_invalidate_phys_range = tb_invalidate_phys_range; } type_init(tcg_module_ops_tb); diff --git a/cpu.c b/cpu.c index b8ac817cb3fd..536bb6911a58 100644 --- a/cpu.c +++ b/cpu.c @@ -222,7 +222,7 @@ const char *parse_cpu_option(const char *cpu_option) void tb_invalidate_phys_addr(tb_page_addr_t addr) { mmap_lock(); - tb_invalidate_phys_range(addr, addr + 1); + tcg.tb_invalidate_phys_range(addr, addr + 1); mmap_unlock(); } #else @@ -243,7 +243,7 @@ void tb_invalidate_phys_addr(AddressSpace *as, hwaddr addr, MemTxAttrs attrs) return; } ram_addr = memory_region_get_ram_addr(mr) + addr; - tb_invalidate_phys_range(ram_addr, ram_addr + 1); + tcg.tb_invalidate_phys_range(ram_addr, ram_addr + 1); } #endif diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 85cb03e176c1..0f4cfefe01cb 100644 --- a/linux-user/mmap.c +++ b/linux-user/mmap.c @@ -630,7 +630,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int target_prot, if (qemu_loglevel_mask(CPU_LOG_PAGE)) { log_page_dump(__func__); } - tb_invalidate_phys_range(start, start + len); + tcg.tb_invalidate_phys_range(start, start + len); mmap_unlock(); return start; fail: @@ -734,7 +734,7 @@ int target_munmap(abi_ulong start, abi_ulong len) if (ret == 0) { page_set_flags(start, start + len, 0); - tb_invalidate_phys_range(start, start + len); + tcg.tb_invalidate_phys_range(start, start + len); } mmap_unlock(); return ret; @@ -824,7 +824,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size, page_set_flags(new_addr, new_addr + new_size, prot | PAGE_VALID | PAGE_RESET); } - tb_invalidate_phys_range(new_addr, new_addr + new_size); + tcg.tb_invalidate_phys_range(new_addr, new_addr + new_size); mmap_unlock(); return new_addr; } diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 8b27827c533d..f2301f4445cc 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -2696,7 +2696,7 @@ static void invalidate_and_set_dirty(MemoryRegion *mr, hwaddr addr, } if (dirty_log_mask & (1 << DIRTY_MEMORY_CODE)) { assert(tcg_enabled()); - tb_invalidate_phys_range(addr, addr + length); + tcg.tb_invalidate_phys_range(addr, addr + length); dirty_log_mask &= ~(1 << DIRTY_MEMORY_CODE); } cpu_physical_memory_set_dirty_range(addr, length, dirty_log_mask); -- 2.31.1