Hi Drew, On 9/8/21 11:14 AM, Andrew Jones wrote: > On Mon, Sep 06, 2021 at 02:31:36PM +0200, Eric Auger wrote: >> This series generates the ACPI DBG2 table along with machvirt. >> It applies on top of Igor's >> [PATCH v2 00/35] acpi: refactor error prone build_header() and >> packed structures usage in ACPI tables >> >> The DBG2 specification can be found at >> https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table. >> >> DBG2 is mandated by ARM SBBR since its v1.0 release (the rationale >> behind is Windows requires it on all systems). >> >> The DBG2 is used to describe a debug port, used by the kernel debugger. > Hi Eric, > > Did you test this in some way with a Linux guest?
no, I don't know how to test it functionaly. As I diff'ed against sbsa-ref generated table maybe guys using the sbsa-ref have some proper testing use case of it? Adding Hongbo and Leif in CC. Thanks Eric > > Thanks, > drew > >> This series and its dependency can be found at >> https://github.com/eauger/qemu.git >> branch: dbg2-v2-igor-v2-fix >> >> History: >> v1 -> v2: >> - rebase on top of Igor's series and use acpi_init_table/acpi_table_composed >> and build_append_int_noprefix() >> >> Eric Auger (3): >> tests/acpi: Add void table for virt/DBG2 bios-tables-test >> bios-tables-test: Generate reference table for virt/DBG2 >> hw/arm/virt_acpi_build: Generate DBG2 table >> >> hw/arm/virt-acpi-build.c | 64 +++++++++++++++++++++++++++++++++++++- >> tests/data/acpi/virt/DBG2 | Bin 0 -> 87 bytes >> 2 files changed, 63 insertions(+), 1 deletion(-) >> create mode 100644 tests/data/acpi/virt/DBG2 >> >> -- >> 2.26.3 >>
