Re: [PATCH 07/20] nubus: add trace-events for unassigned slot accesses

[Mark Cave-Ayland]

On 12/09/2021 16:18, Philippe Mathieu-Daudé wrote:

On 9/12/21 9:49 AM, Mark Cave-Ayland wrote:
These allow tracing of the Nubus enumeration process by the guest OS.
Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
---
  hw/nubus/nubus-bus.c  | 10 +++++++---
  hw/nubus/trace-events |  7 +++++++
  hw/nubus/trace.h      |  1 +
  meson.build           |  1 +
  4 files changed, 16 insertions(+), 3 deletions(-)
  create mode 100644 hw/nubus/trace-events
  create mode 100644 hw/nubus/trace.h

@@ -38,7 +40,7 @@ static const MemoryRegionOps nubus_slot_ops = {
      .endianness = DEVICE_BIG_ENDIAN,
      .valid = {
          .min_access_size = 1,
-        .max_access_size = 1,
+        .max_access_size = 4,
      },
  };

This patch does a bit more that what is described.

Ah oops - presumably one of the OSs I was testing was probing with 32-bit accesses 
instead of 8-bit accesses and I made the adjustment to ensure the bus enumeration for 
empty slots appeared in the trace events.

I'll update the commit message accordingly.

@@ -60,7 +64,7 @@ static const MemoryRegionOps nubus_super_slot_ops = {
      .endianness = DEVICE_BIG_ENDIAN,
      .valid = {
          .min_access_size = 1,
-        .max_access_size = 1,
+        .max_access_size = 4,
      },
  };


ATB,

Mark.