On Fri, Sep 17, 2021 at 04:31:33PM +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> 65 files changed, 48 insertions(+), 48 deletions(-) The diff is harder to read in email (due to file rename comparison sometimes going astray on short and similar file contents) when compared to applying the patch and inspecting the directory proper, but either way, it looks okay to me. > +++ b/tests/qapi-schema/meson.build > @@ -107,22 +107,6 @@ schemas = [ > 'features-name-bad-type.json', > 'features-no-list.json', > 'features-unknown-key.json', > - 'flat-union-array-branch.json', > - 'flat-union-bad-base.json', > - 'flat-union-bad-discriminator.json', > - 'flat-union-base-any.json', > - 'flat-union-base-union.json', > - 'flat-union-clash-member.json', > - 'flat-union-discriminator-bad-name.json', > - 'flat-union-empty.json', > - 'flat-union-inline-invalid-dict.json', > - 'flat-union-int-branch.json', > - 'flat-union-invalid-branch-key.json', > - 'flat-union-invalid-discriminator.json', > - 'flat-union-invalid-if-discriminator.json', > - 'flat-union-no-base.json', > - 'flat-union-optional-discriminator.json', > - 'flat-union-string-discriminator.json', > 'funny-char.json', > 'funny-word.json', > 'ident-with-escape.json', > @@ -190,12 +174,28 @@ schemas = [ > 'unclosed-list.json', > 'unclosed-object.json', > 'unclosed-string.json', > + 'union-array-branch.json', > + 'union-bad-base.json', > + 'union-bad-discriminator.json', > + 'union-base-any.json', > 'union-base-empty.json', > 'union-base-no-discriminator.json', > + 'union-base-union.json', > 'union-branch-if-invalid.json', > 'union-branch-invalid-dict.json', > + 'union-clash-member.json', > + 'union-discriminator-bad-name.json', > + 'union-empty.json', > + 'union-inline-invalid-dict.json', > + 'union-int-branch.json', > 'union-invalid-base.json', > + 'union-invalid-branch-key.json', > 'union-invalid-data.json', > + 'union-invalid-discriminator.json', > + 'union-invalid-if-discriminator.json', > + 'union-no-base.json', > + 'union-optional-discriminator.json', > + 'union-string-discriminator.json', > 'union-unknown.json', This is probably the best part of the patch to focus on. Reviewed-by: Eric Blake <ebl...@redhat.com -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
