On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
> > Reported-by: Warner Losh <i...@bsdimp.com>
> > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> > ---
> > bsd-user/meson.build | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/bsd-user/meson.build b/bsd-user/meson.build
> > index 03695493408..a7607e1c884 100644
> > --- a/bsd-user/meson.build
> > +++ b/bsd-user/meson.build
> > @@ -1,3 +1,7 @@
> > +if not config_host.has_key('CONFIG_BSD')
> > + subdir_done()
> > +endif
> > +
> > bsd_user_ss.add(files(
> > 'bsdload.c',
> > 'elfload.c',
>
>
> So, what's the reason for this change?
https://lore.kernel.org/qemu-devel/canczdfprc16ezjqcwjmyeapx6eym9nxsoqatbagr+czis4r...@mail.gmail.com/
linux-user/meson.build is evaluated on bsd, and bsd-user/meson.build on Linux.
> The commit messages and
> the cover letter don't really explain it. Is this fixing a bug
> (if so what?), a precaution to avoid possible future bugs,
> fixing a performance issue with how long meson takes to run (if
> so, how much effect does this have), or something else?
I'll wait for feedback from Paolo, then work on the explanation.
Regards,
Phil.
