Richard & Alistair, On Tue, 28 Sept 2021 at 20:45, Philipp Tomsich <philipp.toms...@vrull.eu> wrote: > > On Tue, 28 Sept 2021 at 20:45, Richard Henderson > <richard.hender...@linaro.org> wrote: > > > > On 9/28/21 11:45 AM, Philipp Tomsich wrote: > > > The dup_const macro is returning an unsigned long long, which probably > > > should be fixed on the tcg.h-level instead of forcing a cast to > > > target_long > > > at the call site. > > > > No, dup_const is first and primarily for vector support, and therefore must > > return a > > 64-bit constant. > > > > > Or should we introduce a dup_const_tl? > > > > Maybe. I guess that could be a bit better than the cast. > > I'll provide a patch that wraps dup_const in a dup_const_tl.
A fix is in patchworks: https://patchwork.kernel.org/project/qemu-devel/list/?series=554539 Thanks, Philipp.
