On Wed, Sep 29, 2021 at 01:30:50AM -0400, ~farzon wrote: > From: Farzon Lotfi <h...@farzon.org>
Food for thought: your git/mail configuration used one address for the envelope (name '~farzon' as user 'farzon@') and another as the patch author (name 'Farzon Lotfi' as user 'hi@'). Since you own your domain (with its own perks), you can get away with it, but it looks a bit less professional to need a second From: line to override the mail author (which is more commonly needed to work around overly strict DKIM settings), compared to just sending your mail from the desired full-name author in the first place. But since your Signed-off-by tag is correct, this is not a show-stopper to applying your patch. However, my next comment does require a respin before your patch would be ready. Your Subject: line is too long, as evidenced by your choice of using sentences. It should really be 'category: short description' all within 60 characters or so (when 'git log' displays indentation, a short commit id, and then your subject, you don't want your subject truncated). It feels like some of your subject should instead be part of the commit body, where you currently have only... > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 ...because that one line as a body is rather sparse. While the URL is nice (it is a lifesaver for tracking whether a particular bug has a known patch), it does not tell me at a glance what is behind that URL, and I don't want to have to fire up my browser to learn about your patch. In general, the subject should be a short "what", and the commit body should be "why" a maintainer should apply it. I'd suggest the following: block: Replace TABs with space Bring the block file in line with the QEMU coding style, with spaces for indentation. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371 > > Signed-off-by: Farzon Lotfi <h...@farzon.org> > --- -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org