On Mon, Sep 20, 2021 at 10:06:09AM +0200, Igor Mammedov wrote: > > +/* > > + * Generate a VIOT table with one PCI-based virtio-iommu that manages PCI > > + * endpoints. > > We usually put a pointer to spec/revision and chapter in it > that describes being implemented table, so reviewer would > have a reference to compare code with. Otherwise I have no > idea if implementation is correct or not.
The 6.5 ACPI specification isn't out yet unfortunately, so I can't put any reference at the moment. I don't know when it will be published. The draft specification is here: https://jpbrucker.net/virtio-iommu/viot/viot-v9.pdf But that's only temporary. I can make a note to add the pointers once the spec is out. The acpica implementation could also be used for cross-reference: https://github.com/acpica/acpica/commit/fc4e33319c1ee08f20f5c44853dd8426643f6dfd Thanks, Jean > > ex: build_hmat_mpda > > the same applies to viot_host_bridges >