On Thu, Oct 14, 2021 at 01:25:54PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
>
> Make the '--socket-group=' option fail if the group name is unknown:
>
> ./tools/virtiofsd/virtiofsd .... --socket-group=zaphod
> vhost socket: unable to find group 'zaphod'
>
> Reported-by: Xiaoling Gao <xia...@redhat.com>
> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
Hi Dave,
This looks good to me. Just a minor nit for code cleanup. It could
be done in a separate patch or sometime later as well.
Reviewed-by: Vivek Goyal <vgo...@redhat.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index 8f4fd165b9..39eebffb62 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -999,6 +999,13 @@ static int fv_create_listen_socket(struct fuse_session
> *se)
> "vhost socket failed to set group to %s (%d): %m\n",
> se->vu_socket_group, g->gr_gid);
> }
> + } else {
> + fuse_log(FUSE_LOG_ERR,
> + "vhost socket: unable to find group '%s'\n",
> + se->vu_socket_group);
> + close(listen_sock);
> + umask(old_umask);
^^^
> + return -1;
> }
> }
> umask(old_umask);
This umask() call could be moved little early right after bind() call and
that way we don't have to take care of calling umask(old_umask) in error
path if group name could not be found.
Vivek
> --
> 2.31.1
>
> _______________________________________________
> Virtio-fs mailing list
> virtio...@redhat.com
> https://listman.redhat.com/mailman/listinfo/virtio-fs
>
