On 10/26/21 17:10, Eduardo Habkost wrote: > Rename the enums to match the naming style used by QAPI, and to > use "32" and "64" instead of "20" and "31". This will allow us > to more easily move the enum to the QAPI schema later. > > About the naming choice: "SMBIOS 2.1 entry point"/"SMBIO 3.0 > entry point" and "32-bit entry point"/"64-bit entry point" are > synonymous in the SMBIOS specification. However, the phrases > "32-bit entry point" and "64-bit entry point" are used more often. > > The new names also avoid confusion between the entry point format > and the actual SMBIOS version reported in the entry point > structure. For example: currently the 32-bit entry point > actually report SMBIOS 2.8 support, not 2.1. > > Based on portions of a patch submitted by Daniel P. Berrangé. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > First version of this code was submitted at: > https://lore.kernel.org/qemu-devel/20200908165438.1008942-5-berra...@redhat.com > > Changes from v2: > * Use "32" and "64" instead of "2_0" and "3_1" > > Changes from v1: > * Patch was split in two > * Hunks included this patch are not changed from v1 > --- > include/hw/firmware/smbios.h | 4 ++-- > hw/arm/virt.c | 2 +- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > hw/smbios/smbios.c | 8 ++++---- > 5 files changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
